linux-kernel - Re: [PATCH 1/8] arm/mach-tegra: fix unsigned calcs

Open Source and information security mailing list archives

Message-ID: <4C455614.1000801@compulab.co.il>
Date:	Tue, 20 Jul 2010 10:53:56 +0300
From:	Mike Rapoport <mike@...pulab.co.il>
To:	Colin Cross <ccross@...roid.com>
CC:	Kulikov Vasiliy <segooon@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Erik Gilling <konkers@...roid.com>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-tegra@...r.kernel.org, Olof Johansson <olof@...om.net>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/8] arm/mach-tegra: fix unsigned calcs

Colin Cross wrote:
> On Thu, Jul 15, 2010 at 11:43 AM, Kulikov Vasiliy <segooon@...il.com> wrote:
>> divider_u71 is unsigned, so this check is buggy:
>> if (divider_u71 - 2 > 255 || divider_u71 - 2 < 0)
>>
>> If divider_u71 is 0 or 1 both checks are lying.
>> So, it does not produce a buggy answer, but it is confusing.
> 
> Hi Kulikov,

The first name is Vasiliy :)

> Thanks for the patch.  This problem has been fixed in another patch in
> the linux-tegra tree, I'll post it for review and update the
> linux-next tree soon.
> 
> Colin Cross
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


-- 
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives