linux-kernel - Re: [PATCH 03/16] trivial: use ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1007201706060.4741@pobox.suse.cz>
Date:	Tue, 20 Jul 2010 17:06:19 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Kulikov Vasiliy <segooon@...il.com>
Cc:	Kernel Janitors <kernel-janitors@...r.kernel.org>,
	David Airlie <airlied@...ux.ie>,
	Dave Airlie <airlied@...hat.com>,
	Adam Jackson <ajax@...hat.com>,
	Zhao Yakui <yakui.zhao@...el.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/16] trivial: use ARRAY_SIZE

On Mon, 28 Jun 2010, Kulikov Vasiliy wrote:

> Change sizeof(x) / sizeof(*x) to ARRAY_SIZE(x).
> 
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>
> ---
>  drivers/gpu/drm/drm_edid.c |    7 ++-----
>  1 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index c198186..da06476 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -929,13 +929,11 @@ drm_mode_do_interlace_quirk(struct drm_display_mode *mode,
>  		{ 1440,  576 },
>  		{ 2880,  576 },
>  	};
> -	static const int n_sizes =
> -		sizeof(cea_interlaced)/sizeof(cea_interlaced[0]);
>  
>  	if (!(pt->misc & DRM_EDID_PT_INTERLACED))
>  		return;
>  
> -	for (i = 0; i < n_sizes; i++) {
> +	for (i = 0; i < ARRAY_SIZE(cea_interlaced); i++) {
>  		if ((mode->hdisplay == cea_interlaced[i].w) &&
>  		    (mode->vdisplay == cea_interlaced[i].h / 2)) {
>  			mode->vdisplay *= 2;
> @@ -1375,7 +1373,6 @@ static const struct {
>  	{ 1920, 1440, 60, 0 },
>  	{ 1920, 1440, 75, 0 },
>  };
> -static const int num_est3_modes = sizeof(est3_modes) / sizeof(est3_modes[0]);
>  
>  static int
>  drm_est3_modes(struct drm_connector *connector, struct detailed_timing *timing)
> @@ -1387,7 +1384,7 @@ drm_est3_modes(struct drm_connector *connector, struct detailed_timing *timing)
>  	for (i = 0; i < 6; i++) {
>  		for (j = 7; j > 0; j--) {
>  			m = (i * 8) + (7 - j);
> -			if (m >= num_est3_modes)
> +			if (m >= ARRAY_SIZE(est3_modes))
>  				break;
>  			if (est[i] & (1 << j)) {
>  				mode = drm_mode_find_dmt(connector->dev,

Not found in linux-next as of today. Applied, thanks.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/