linux-kernel - Re: [PATCH 08/16] trivial: use ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 20 Jul 2010 17:15:56 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Kulikov Vasiliy <segooon@...il.com>
Cc:	Kernel Janitors <kernel-janitors@...r.kernel.org>,
	Robert Love <robert.w.love@...el.com>,
	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	Vasu Dev <vasu.dev@...el.com>,
	Joe Eykholt <jeykholt@...co.com>, devel@...n-fcoe.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/16] trivial: use ARRAY_SIZE

On Mon, 28 Jun 2010, Kulikov Vasiliy wrote:

> Change sizeof(x) / sizeof(*x) to ARRAY_SIZE(x).
> 
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>
> ---
>  drivers/scsi/libfc/fc_exch.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c
> index 104e0fb..ca52bfa 100644
> --- a/drivers/scsi/libfc/fc_exch.c
> +++ b/drivers/scsi/libfc/fc_exch.c
> @@ -219,8 +219,6 @@ static void fc_exch_els_rrq(struct fc_seq *, struct fc_frame *);
>   */
>  static char *fc_exch_rctl_names[] = FC_RCTL_NAMES_INIT;
>  
> -#define FC_TABLE_SIZE(x)   (sizeof(x) / sizeof(x[0]))
> -
>  /**
>   * fc_exch_name_lookup() - Lookup name by opcode
>   * @op:	       Opcode to be looked up
> @@ -249,7 +247,7 @@ static inline const char *fc_exch_name_lookup(unsigned int op, char **table,
>  static const char *fc_exch_rctl_name(unsigned int op)
>  {
>  	return fc_exch_name_lookup(op, fc_exch_rctl_names,
> -				   FC_TABLE_SIZE(fc_exch_rctl_names));
> +				   ARRAY_SIZE(fc_exch_rctl_names));
>  }

Applied. Please use better Subject: lines next time though. Having the 
whole series have the same Subject: line doesn't really help.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/