lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Jul 2010 12:21:20 -0700 From: Dave Hansen <dave@...ux.vnet.ibm.com> To: Nathan Fontenot <nfont@...tin.ibm.com> Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, linuxppc-dev@...abs.org, KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>, greg@...ah.com Subject: Re: [PATCH 4/8] v3 Allow memory_block to span multiple memory sections On Mon, 2010-07-19 at 22:55 -0500, Nathan Fontenot wrote: > +static u32 get_memory_block_size(void) > +{ > + u32 block_sz; > + > + block_sz = memory_block_size_bytes(); > + > + /* Validate blk_sz is a power of 2 and not less than section size */ > + if ((block_sz & (block_sz - 1)) || (block_sz < MIN_MEMORY_BLOCK_SIZE)) > + block_sz = MIN_MEMORY_BLOCK_SIZE; Is this worth a WARN_ON()? Seems pretty bogus if someone is returning funky block sizes. -- Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists