lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1279662370.2899.13.camel@sbs-t61.sc.intel.com>
Date:	Tue, 20 Jul 2010 14:46:10 -0700
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Robert Richter <robert.richter@....com>
Cc:	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/10] x86, xsave: do not include asm/i387.h in
 asm/xsave.h

On Tue, 2010-07-20 at 11:50 -0700, Robert Richter wrote:
> There are no dependencies to asm/i387.h. Instead, if including only
> xsave.h the following error occurs:
> 
>  .../arch/x86/include/asm/i387.h:110: error: ‘XSTATE_FP’ undeclared (first use in this function)
>  .../arch/x86/include/asm/i387.h:110: error: (Each undeclared identifier is reported only once
>  .../arch/x86/include/asm/i387.h:110: error: for each function it appears in.)
> 
> This patch fixes this.
> 
> Signed-off-by: Robert Richter <robert.richter@....com>
> ---
>  arch/x86/include/asm/xsave.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/include/asm/xsave.h b/arch/x86/include/asm/xsave.h
> index ec86c5f..94d5f84 100644
> --- a/arch/x86/include/asm/xsave.h
> +++ b/arch/x86/include/asm/xsave.h
> @@ -3,7 +3,6 @@
>  
>  #include <linux/types.h>
>  #include <asm/processor.h>
> -#include <asm/i387.h>
>  
>  #define XSTATE_FP	0x1
>  #define XSTATE_SSE	0x2

Acked-by: Suresh Siddha <suresh.b.siddha@...el.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ