linux-kernel - RE: [PATCH 4/4] input: dynamically allocate ABS information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1279708968.2306.11.camel@localhost>
Date:	Wed, 21 Jul 2010 13:42:48 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	ext-phil.2.carmody@...ia.com
Cc:	dmitry.torokhov@...il.com, daniel@...aq.de,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: RE: [PATCH 4/4] input: dynamically allocate ABS information

On Wed, 2010-07-21 at 11:22 +0200, ext-phil.2.carmody@...ia.com wrote:
> A tiny tiny nit...
> 
> From: Dmitry Torokhov [dmitry.torokhov@...il.com]
> ...
> +void input_alloc_absinfo(struct input_dev *dev)
> +{
> +       if (!dev->absinfo)
> +               dev->absinfo = kcalloc(ABS_CNT, sizeof(struct input_absinfo),
> +                                       GFP_KERNEL);
> +
> +       WARN(!dev->absinfo, "%s(): kzalloc() failed?\n", __func__);
> 
> kcalloc failed, not kzalloc.

kmalloc and friends already print a warning with a stack dump when they
fail, unless this is overrided with __GFP_NOWARN, which is not the case
here. So in usually we do not print messages/warnigns when we fail to
allocate.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/