linux-kernel - Re: [PATCH 00/26] cciss updates July 19, 2010

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 20 Jul 2010 20:05:10 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	"Stephen M. Cameron" <scameron@...rdog.cce.hp.com>
CC:	akpm@...ux-foundation.org, mikem@...rdog.cce.hp.com,
	linux-kernel@...r.kernel.org, brace@...rdog.cce.hp.com
Subject: Re: [PATCH 00/26] cciss updates July 19, 2010

On 07/19/2010 12:44 PM, Stephen M. Cameron wrote:
> The following series implements mostly cleanups to the initialization
> code in cciss along the same lines as what's already been done in hpsa.
> 
> There are also a few bug fixes.  The SCSI tape code was not setting the
> performant mode bits in commands, which caused a hang.  The code to
> reset controllers via PCI power management methods only works on old
> controllers, so an alternate method is used for newer controllers.
> 
> There are a couple of big patches to make cciss use more consistent
> variable names (always h for hba, and c for command, rather than a
> mishmash of various things names) and to generally use dev_warn, etc.
> instead of printk.
> 
> These patches apply to the 'for-2.6.36' branch of Jens Axboe's git
> tree: http://git.kernel.org/?p=linux/kernel/git/axboe/linux-2.6-block.git;a=summary
> (there are many changes to cciss in that tree on which these patches depend.)

I have applied these, but please next time don't duplicate in the
body what you already put in the subject. We end up with logs like:

    cciss: change printks to dev_warn, etc.
    
    cciss: change printks to dev_warn, etc.
    
    Signed-off-by: Stephen M. Cameron <scameron@...rdog.cce.hp.com>

which is not too pretty.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/