linux-kernel - Re: [PATCHv2 04/11] writeback: do not lose wake-ups in the forker thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100721115725.GB28745@infradead.org>
Date:	Wed, 21 Jul 2010 07:57:25 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Artem Bityutskiy <dedekind1@...il.com>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 04/11] writeback: do not lose wake-ups in the forker
 thread - 2

On Wed, Jul 21, 2010 at 12:31:39PM +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy@...ia.com>
> 
> Currently, if someone submits jobs for the default bdi, we can lose wake-up
> events. E.g., this can happen if 'bdi_queue_work()' is called when
> 'bdi_forker_thread()' is executing code after 'wb_do_writeback(me, 0)', but
> before 'set_current_state(TASK_INTERRUPTIBLE)'.
> 
> This situation is unlikely, and the result is not very severe - we'll just
> delay the execution of the work, but this is still not very nice.
> 
> This patch fixes the issue by checking whether the default bdi has works before
> the forker thread goes sleep.

Looks good,


Reviewed-by: Christoph Hellwig <hch@....de>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/