linux-kernel - Re: [PATCH 4/8] vmscan: Do not writeback filesystem pages in direct reclaim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100721150629.GB13117@csn.ul.ie>
Date:	Wed, 21 Jul 2010 16:06:29 +0100
From:	Mel Gorman <mel@....ul.ie>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-mm@...ck.org, Dave Chinner <david@...morbit.com>,
	Chris Mason <chris.mason@...cle.com>,
	Nick Piggin <npiggin@...e.de>, Rik van Riel <riel@...hat.com>,
	Christoph Hellwig <hch@...radead.org>,
	Wu Fengguang <fengguang.wu@...el.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andrea Arcangeli <aarcange@...hat.com>
Subject: Re: [PATCH 4/8] vmscan: Do not writeback filesystem pages in
	direct reclaim

On Wed, Jul 21, 2010 at 04:39:56PM +0200, Johannes Weiner wrote:
> On Wed, Jul 21, 2010 at 03:31:19PM +0100, Mel Gorman wrote:
> > On Wed, Jul 21, 2010 at 04:28:44PM +0200, Johannes Weiner wrote:
> > > On Wed, Jul 21, 2010 at 02:38:57PM +0100, Mel Gorman wrote:
> > > > @@ -858,7 +872,7 @@ keep:
> > > >  
> > > >  	free_page_list(&free_pages);
> > > >  
> > > > -	list_splice(&ret_pages, page_list);
> > > 
> > > This will lose all retry pages forever, I think.
> > > 
> > 
> > Above this is
> > 
> > while (!list_empty(page_list)) {
> > 	...
> > }
> > 
> > page_list should be empty and keep_locked is putting the pages on ret_pages
> > already so I think it's ok.
> 
> But ret_pages is function-local.  Putting them back on the then-empty
> page_list is to give them back to the caller, otherwise they are lost
> in a dead stack slot.
> 

Bah, you're right, it is repaired now. /me slaps self. Thanks

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/