linux-kernel - Re: [PATCH 4/7] cifs: use workqueue instead of slow-work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTilSR15Cmz-dTyIDvOl-qdYrQ6x84BY7f9LggElW@mail.gmail.com>
Date:	Wed, 21 Jul 2010 10:46:11 -0500
From:	Steve French <smfrench@...il.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org, dhowells@...hat.com,
	sfrench@...ba.org, anton@...ba.org, swhiteho@...hat.com,
	airlied@...ux.ie, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 4/7] cifs: use workqueue instead of slow-work

On Tue, Jul 20, 2010 at 3:34 PM, Tejun Heo <tj@...nel.org> wrote:
> Workqueue can now handle high concurrency.  Use system_nrt_wq
> instead of slow-work.
>
> * Updated is_valid_oplock_break() to not call cifs_oplock_break_put()
>  as advised by Steve French.  It might cause deadlock.  Instead,
>  reference is increased after queueing succeeded and
>  cifs_oplock_break() briefly grabs GlobalSMBSeslock before putting
>  the cfile to make sure it doesn't put before the matching get is
>  finished.
>
> * Anton Blanchard reported that cifs conversion was using now gone
>  system_single_wq.  Use system_nrt_wq which provides non-reentrance
>  guarantee which is enough and much better.
>
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Steve French <sfrench@...ba.org>
> Cc: Anton Blanchard <anton@...ba.org>
> ---
>  fs/cifs/Kconfig    |    1 -
>  fs/cifs/cifsfs.c   |    5 -----
>  fs/cifs/cifsglob.h |    8 +++++---
>  fs/cifs/dir.c      |    2 +-
>  fs/cifs/file.c     |   30 +++++++++++++-----------------
>  fs/cifs/misc.c     |   20 ++++++++++++--------
>  6 files changed, 31 insertions(+), 35 deletions(-)

Acked-by: Steve French <sfrench@...ibm.com>



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/