linux-kernel - Re: [RFC PATCH] use acpi_idle_enter_simple if bm_check && !.bm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <alpine.LFD.2.00.1007211725530.409@localhost.localdomain>
Date:	Wed, 21 Jul 2010 17:29:00 -0400 (EDT)
From:	Len Brown <lenb@...nel.org>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Luming Yu <luming.yu@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>,
	"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
	Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [RFC PATCH] use acpi_idle_enter_simple if bm_check && !.bm_control

On Mon, 19 Apr 2010, Matthew Garrett wrote:

> On Tue, Nov 10, 2009 at 02:12:41PM +0800, Luming Yu wrote:
> 
> > I came across acpi processor idle driver, noticed that we can cut a
> > bit overhead at C3 entry that can improve C3 residency a bit,
> > especially when it has similar kernel config as old RHEL 5 kernel
> > (2.6.18) on systems with as many as 64 logical CPUs. The point of this
> > patch is bm_sts is an optional bit. It never returns 1 on systems with
> > bm_check && !bm_control I tested. Instead, I have observed lower C3
> > residency due to accessing bm_sts and relevant code on a system with
> > 64 logical CPUs with HZ=1000. Please review. If make sense, please
> > apply.
> 
> Saves 40W or so on a dual-socket Nehalem system here. Is there a reason 
> it wasn't picked up?

The reason it wasn't picked up is because it assumed that the need
for checking BM_STS is identical to the ability to use ARB_DIS.

However, the two are entirely independent.  The result is that
with the patch we would stop checking BM_STS for every Core2 Duo
system -- which would be incorrect.

thanks,
Len Brown, Intel Open Source Technology Center



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/