linux-kernel - Re: BUG at drivers/scsi/scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100722173716.66264bef@notabene>
Date:	Thu, 22 Jul 2010 17:37:16 +1000
From:	Neil Brown <neilb@...e.de>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	James Bottomley <James.Bottomley@...e.de>,
	linux-scsi@...r.kernel.org, hch@....de, jaxboe@...ionio.com,
	LKML <linux-kernel@...r.kernel.org>, linux-raid@...r.kernel.org
Subject: Re: BUG at drivers/scsi/scsi_lib.c:1113

On Thu, 22 Jul 2010 09:04:27 +0200
Jiri Slaby <jirislaby@...il.com> wrote:

> Hello,
> 
> I'm seeing this BUG while booting:
> 
> EXT3-fs (md1): using internal journal
> ------------[ cut here ]------------
> kernel BUG at /home/l/latest/xxx/drivers/scsi/scsi_lib.c:1113!

You aren't the only one.
https://bugzilla.kernel.org/show_bug.cgi?id=16275


> I bisected it down to:
> commit 74450be123b6f3cb480c358a056be398cce6aa6e
> Author: Christoph Hellwig <hch@....de>
> Date:   Fri Jun 18 11:53:43 2010 +0200
> 
>     block: unify flags for struct bio and struct request
> 
>     Remove the current bio flags and reuse the request flags for the
> bio, too.
>     This allows to more easily trace the type of I/O from the filesystem
>     down to the block driver.  There were two flags in the bio that were
>     missing in the requests:  BIO_RW_UNPLUG and BIO_RW_AHEAD.  Also I've
>     renamed two request flags that had a superflous RW in them.
> 
>     Note that the flags are in bio.h despite having the REQ_ name - as
>     blkdev.h includes bio.h that is the only way to go for now.
> 
>     Signed-off-by: Christoph Hellwig <hch@....de>
>     Signed-off-by: Jens Axboe <jaxboe@...ionio.com>
> 
>

Thanks for doing that.

I suspect that problem is that "do_sync" and "do_barriers" in
drivers/md/raid1.c are still 'bool' and should now be 'unsigned long'.

I'm not sure how wide '_Bool' is, but I'm guess it isn't wide enough.

Could you please try changing ever 'bool' in that file to 'unsigned long'
and see if that fixes it?

Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/