linux-kernel - Re: [PATCH 2/7] x86, xsave: introduce xstate enable functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C48385C.9040309@zytor.com>
Date:	Thu, 22 Jul 2010 05:23:56 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Robert Richter <robert.richter@....com>
CC:	Suresh Siddha <suresh.b.siddha@...el.com>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/7] x86, xsave: introduce xstate enable functions

On 07/22/2010 05:15 AM, Robert Richter wrote:
> 
> Just wondering why you are using this_func()? Instead, you could
> simply do:
> 
> 	next_func();
> 	next_func = xstate_enable;
> 
> Do you see races when bringing up multiple cpus in parallel?
> 

It allows the compiler to turn it into a tailcall if frame pointers are
disabled.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/