linux-kernel - Re: [RFC][PATCH v1 06/15] perf: export tracepoint events via sysfs: iwlwifi and iwlwifi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100722134836.GA6881@elte.hu>
Date:	Thu, 22 Jul 2010 15:48:36 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Johannes Berg <johannes@...solutions.net>,
	Lin Ming <ming.m.lin@...el.com>,
	Reinette Chatre <reinette.chatre@...el.com>,
	Robert Richter <robert.richter@....com>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Greg KH <greg@...ah.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	"eranian@...il.com" <eranian@...il.com>,
	"Gary.Mohr@...l.com" <Gary.Mohr@...l.com>,
	"arjan@...ux.intel.com" <arjan@...ux.intel.com>,
	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>,
	Paul Mackerras <paulus@...ba.org>,
	"David S. Miller" <davem@...emloft.net>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Will Deacon <will.deacon@....com>,
	Maynard Johnson <mpjohn@...ibm.com>,
	Carl Love <carll@...ibm.com>,
	Kay Sievers <kay.sievers@...y.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC][PATCH v1 06/15] perf: export tracepoint events via sysfs:
 iwlwifi and iwlwifi_io


* Steven Rostedt <rostedt@...dmis.org> wrote:

> On Thu, 2010-07-22 at 13:20 +0200, Johannes Berg wrote:
> > On Thu, 2010-07-22 at 19:13 +0800, Lin Ming wrote:
> > > iwlwifi and iwlwifi_io tracepoint events are exported like below,
> > 
> > >  drivers/net/wireless/iwlwifi/iwl3945-base.c |   15 +++++++++++++++
> > >  1 files changed, 15 insertions(+), 0 deletions(-)
> > 
> > err, how about iwlagn?
> 
> A lot of work went into making the include/trace/events/*.h be able to 
> automate the work. Now it seems that we are going to hand code a lot, and a 
> developer that adds a new system or such will now need to understand the 
> internals of perf to use it. That was what I strived to avoid when creating 
> the TRACE_EVENT() macros.

Yeah - and the point of this submission is to allow the discussion of how to 
achieve these registrations.

Driver authors will want to have some control - for example the place where 
the events directory shows up in sysfs within the driver's directory structure 
- etc.

But we indeed want to automate it as much as possible.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/