linux-kernel - Re: [PATCH] Staging: dt3155: Remove copy_to_user for ioctl's DT3155

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100722175535.GA28673@kroah.com>
Date:	Thu, 22 Jul 2010 10:55:35 -0700
From:	Greg KH <greg@...ah.com>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	H Hartley Sweeten <hartleys@...ionengravers.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org, ss@....gov.au, gregkh@...e.de
Subject: Re: [PATCH] Staging: dt3155: Remove copy_to_user for ioctl's
 DT3155_{STOP|START}

On Wed, Jul 21, 2010 at 09:57:16AM +0200, Jiri Slaby wrote:
> On 07/21/2010 02:57 AM, H Hartley Sweeten wrote:
> > The ioctl's DT3155_STOP and DT3155_START are defined with the macro
> > _IO indicating that they have no parameters. They should not be using
> > copy_to_user to return data to user space.
> 
> This is not a reason for removing them. You should check what real users
> do/expect and base your reasoning on the top of that.
> 
> So could you investigate that?

I agree, we can't remove this, it changes the functionality of the
kernel in a way that userspace might not be expecting.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/