linux-kernel - Re: [PATCH] Staging: comedi: drivers: Code style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100722184757.GA14820@kroah.com>
Date:	Thu, 22 Jul 2010 11:47:57 -0700
From:	Greg KH <greg@...ah.com>
To:	Chihau Chau <chihau@...il.com>
Cc:	gregkh@...e.de, mithlesh@...syssoft.com, reodge@...il.com,
	andrea.gelmini@...ma.net, penberg@...helsinki.fi,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: drivers: Code style issues

On Thu, Jul 22, 2010 at 01:07:53PM -0400, Chihau Chau wrote:
> From: Chihau Chau <chihau@...il.com>
> 
> This fix some lines over 80 characters.
> 
> Signed-off-by: Chihau Chau <chihau@...il.com>
> ---
>  drivers/staging/comedi/drivers.c |   17 ++++++++---------
>  1 files changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
> index 4a29ed7..50c8295 100644
> --- a/drivers/staging/comedi/drivers.c
> +++ b/drivers/staging/comedi/drivers.c
> @@ -117,8 +117,8 @@ int comedi_device_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  
>  	for (driv = comedi_drivers; driv; driv = driv->next) {
>  		if (!try_module_get(driv->module)) {
> -			printk
> -			    (KERN_INFO "comedi: failed to increment module count, skipping\n");
> +			printk(KERN_INFO "comedi: failed to increment module "
> +				"count, skipping\n");

No, please don't break strings across lines like this, it makes it
harder to grep for things.

How about something like:
			printk(KERN_INFO "comedi: failed to increment module count, skipping\n");
instead.  That should pass the checkpatch.pl script, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/