[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100722191630.GC10307@redhat.com>
Date: Thu, 22 Jul 2010 22:16:30 +0300
From: Gleb Natapov <gleb@...hat.com>
To: Arnaldo Carvalho de Melo <acme@...radead.org>
Cc: linux-kernel@...r.kernel.org, mingo@...e.hu, peterz@...radead.org,
paulus@...ba.org
Subject: Re: [PATCH v2] Re: perf annotate segfaults when source code has
goto label that looks like hex number
On Thu, Jul 22, 2010 at 04:11:32PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jul 22, 2010 at 09:05:38PM +0300, Gleb Natapov escreveu:
> > On Thu, Jul 22, 2010 at 02:05:42PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, Jul 22, 2010 at 01:52:22PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > > Em Thu, Jul 22, 2010 at 01:47:11PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > > It could be a comment of play code, like:
>
> > > > while(1) {
> > > > if (++i == 10000000)
> > > > goto add;
> > > > }
> > > > add: return 0;
>
> > > What about this one?
>
> > > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
> > > @@ -976,13 +976,15 @@ static int hist_entry__parse_objdump_line(struct hist_entry *self, FILE *file,
> > > if (line_ip != -1) {
> > > u64 start = map__rip_2objdump(self->ms.map, sym->start);
> > > offset = line_ip - start;
> > > + if (offset < 0 || (u64)line_ip > sym->end)
> > > + offset = -1;
>
> > This part is good idea anyway. Even if label will be interpreted as ip
> > perf at least will not crash. It may miss-report something if check will
> > accidentally succeed though.
>
> Yeah, we can possibly find a label which is a valid hex number and that
> falls inside the address range, but with what we have in objdump this
> seems to be the best we can have, I'll commit this.
>
Agree. Definitely better that what we have now. Thanks.
--
Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists