linux-kernel - Re: [PATCH 3/6] Driver core: Fix memory leak on class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100722234141.GC674@kroah.com>
Date:	Thu, 22 Jul 2010 16:41:41 -0700
From:	Greg KH <greg@...ah.com>
To:	Patrick Pannuto <ppannuto@...eaurora.org>
Cc:	linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>,
	Andi Kleen <ak@...ux.intel.com>,
	Stephen Hemminger <shemminger@...tta.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Hans J. Koch" <hjk@...utronix.de>
Subject: Re: [PATCH 3/6] Driver core: Fix memory leak on class_register
 error path

On Thu, Jul 22, 2010 at 03:09:03PM -0700, Patrick Pannuto wrote:
> This leak is the same as the bus path; cp's kobj name
> is set, but kset_register fails, free'ing cp, but not
> cp->class_subsys.kobj.name

Same objection here, I don't like how you are having to "know" about how
kobject names are handled here.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/