linux-kernel - [tip:x86/urgent] x86: Do not try to disable hpet if it hasn't been initialized before

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-ff4878089e1eaeac79d57878ad4ea32910fb4037@git.kernel.org>
Date:	Fri, 23 Jul 2010 10:54:52 GMT
From:	tip-bot for Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	tglx@...utronix.de, venki@...gle.com,
	stefano.stabellini@...citrix.com
Subject: [tip:x86/urgent] x86: Do not try to disable hpet if it hasn't been initialized before

Commit-ID:  ff4878089e1eaeac79d57878ad4ea32910fb4037
Gitweb:     http://git.kernel.org/tip/ff4878089e1eaeac79d57878ad4ea32910fb4037
Author:     Stefano Stabellini <stefano.stabellini@...citrix.com>
AuthorDate: Wed, 21 Jul 2010 18:32:37 +0100
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Fri, 23 Jul 2010 12:53:00 +0200

x86: Do not try to disable hpet if it hasn't been initialized before

hpet_disable is called unconditionally on machine reboot if hpet support
is compiled in the kernel.
hpet_disable only checks if the machine is hpet capable but doesn't make
sure that hpet has been initialized.

[ tglx: Made it a one liner and removed the redundant hpet_address check ]

Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
Acked-by: Venkatesh Pallipadi <venki@...gle.com>
LKML-Reference: <alpine.DEB.2.00.1007211726240.22235@...all-desktop>
Cc: stable@...nel.org
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 arch/x86/kernel/hpet.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
index a198b7c..ba390d7 100644
--- a/arch/x86/kernel/hpet.c
+++ b/arch/x86/kernel/hpet.c
@@ -964,7 +964,7 @@ fs_initcall(hpet_late_init);
 
 void hpet_disable(void)
 {
-	if (is_hpet_capable()) {
+	if (is_hpet_capable() && hpet_virt_address) {
 		unsigned int cfg = hpet_readl(HPET_CFG);
 
 		if (hpet_legacy_int_enabled) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/