linux-kernel - Re: [PATCHv4 14/14] writeback: add new tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100723162919.GD29633@infradead.org>
Date:	Fri, 23 Jul 2010 12:29:19 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Artem Bityutskiy <dedekind1@...il.com>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4 14/14] writeback: add new tracepoints

On Fri, Jul 23, 2010 at 06:05:54PM +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy@...ia.com>
> 
> Add 2 new trace points to the periodic write-back wake up case, just like we do
> in the 'bdi_queue_work()' function. Namely, introduce:
> 
> 1. trace_writeback_wakeup(bdi)
> 2. trace_writeback_wakeup_nothread(bdi)
> 
> The first event is triggered every time we wake up a bdi thread to start
> periodic background write-out. The second event is triggered only when the bdi
> thread does not exist and should be created by the forker thread.
> 
> This patch was suggested by Dave Chinner <david@...morbit.com>

As mentioned before doing the wakeup just for the case where we
really wake up the flusher thead is much better.  It's not 100%
clear for bdi_queue_work as we queue the work in either case, but
I'd prefer to fix that one up as well (not in your series anyway)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/