linux-kernel - Re: [PATCH] Staging: dt3155: make local variables static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1279911528.24768.1689.camel@Joe-Laptop.home>
Date:	Fri, 23 Jul 2010 11:58:48 -0700
From:	Joe Perches <joe@...ches.com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org, ss@....gov.au, gregkh@...e.de
Subject: Re: [PATCH] Staging: dt3155: make local variables static

On Fri, 2010-07-23 at 11:45 -0700, H Hartley Sweeten wrote:
> The symbols dt3155_dev_open, unique_tag, and allocatorAddr are only used in
> the file dt3155_drv.c and should be static.
> diff --git a/drivers/staging/dt3155/dt3155_drv.c b/drivers/staging/dt3155/dt3155_drv.c
> index 9e7b880..49924d0 100644
> --- a/drivers/staging/dt3155/dt3155_drv.c
> +++ b/drivers/staging/dt3155/dt3155_drv.c
> @@ -118,14 +118,14 @@ static void __iomem *dt3155_lbase[MAXBOARDS] = { NULL
[]
> -u32  dt3155_dev_open[MAXBOARDS] = {0
> +static u32  dt3155_dev_open[MAXBOARDS] = {0
[]
> -u32 unique_tag = 0;;
> +static u32 unique_tag = 0;;

Statics don't need initialization and could you fix
the style issues ("{0", ";;") at the same time please?

static u32 dt3155_dev_open[MAXBOARDS];
static u32 unique_tag;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/