linux-kernel - Re: [PATCH] char: mxser: remove unnesesary NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C49EB1B.1030700@gmail.com>
Date:	Fri, 23 Jul 2010 21:18:51 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Kulikov Vasiliy <segooon@...il.com>
CC:	kernel-janitors@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Alan Cox <alan@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: mxser: remove unnesesary NULL check

On 07/23/2010 06:34 PM, Kulikov Vasiliy wrote:
> mxser_transmit_chars(tty, port) is called only from mxser_interrupt().
> NULL check is performed in mxser_interrupt() so it is redundant here.
> 
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>

Acked-by: Jiri Slaby <jirislaby@...il.com>

> ---
>  drivers/char/mxser.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
> index d2692d4..3fc89da 100644
> --- a/drivers/char/mxser.c
> +++ b/drivers/char/mxser.c
> @@ -2193,7 +2193,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port
>  	port->mon_data.up_txcnt += (cnt - port->xmit_cnt);
>  	port->icount.tx += (cnt - port->xmit_cnt);
>  
> -	if (port->xmit_cnt < WAKEUP_CHARS && tty)
> +	if (port->xmit_cnt < WAKEUP_CHARS)
>  		tty_wakeup(tty);
>  
>  	if (port->xmit_cnt <= 0) {


-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/