[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1279864434-8010-3-git-send-email-axel.lin@gmail.com>
Date: Fri, 23 Jul 2010 05:53:44 +0000
From: Axel Lin <axel.lin@...il.com>
To: linux-kernel <linux-kernel@...r.kernel.org>
Cc: Barry Song <21cnbao@...il.com>,
Kuninori Morimoto <morimoto.kuninori@...esas.com>,
Mark Brown <broonie@...nsource.wolfsonmicro.com>,
Mike Arthur <linux@...fsonmicro.com>,
Guennadi Liakhovetski <g.liakhovetski@....de>,
Liam Girdwood <lrg@...mlogic.co.uk>
Subject: [PATCH v2 02/12] ak4642: fix a memory leak if failed to initialise AK4642
ak4642 should be kfreed if ak4642_init() return error.
Signed-off-by: Axel Lin <axel.lin@...il.com>
Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
---
sound/soc/codecs/ak4642.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/ak4642.c b/sound/soc/codecs/ak4642.c
index 7528a54..4feefa8 100644
--- a/sound/soc/codecs/ak4642.c
+++ b/sound/soc/codecs/ak4642.c
@@ -491,8 +491,10 @@ static int ak4642_i2c_probe(struct i2c_client *i2c,
codec->control_data = i2c;
ret = ak4642_init(ak4642);
- if (ret < 0)
+ if (ret < 0) {
printk(KERN_ERR "failed to initialise AK4642\n");
+ kfree(ak4642);
+ }
return ret;
}
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists