linux-kernel - Re: [PATCH wq#for-next] fscache: fix build on !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C4CB841.8010804@oracle.com>
Date:	Sun, 25 Jul 2010 15:18:41 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Tejun Heo <tj@...nel.org>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH wq#for-next] fscache: fix build on !CONFIG_SYSCTL

On 07/24/10 02:14, Tejun Heo wrote:
> Commit 8b8edefa (fscache: convert object to use workqueue instead of
> slow-work) made fscache_exit() call unregister_sysctl_table()
> unconditionally breaking build when sysctl is disabled.  Fix it by
> putting it inside CONFIG_SYSCTL.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Reported-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: David Howells <dhowells@...hat.com>
> ---
> This should fix it.  Thanks.

Ack.  Thanks.

> 
>  fs/fscache/main.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/fscache/main.c b/fs/fscache/main.c
> index 500936d..f9d8567 100644
> --- a/fs/fscache/main.c
> +++ b/fs/fscache/main.c
> @@ -186,7 +186,9 @@ static void __exit fscache_exit(void)
> 
>  	kobject_put(fscache_root);
>  	kmem_cache_destroy(fscache_cookie_jar);
> +#ifdef CONFIG_SYSCTL
>  	unregister_sysctl_table(fscache_sysctl_header);
> +#endif
>  	fscache_proc_cleanup();
>  	destroy_workqueue(fscache_op_wq);
>  	destroy_workqueue(fscache_object_wq);


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/