linux-kernel - Re: [PATCHv5 12/15] writeback: optimize periodic bdi thread wakeups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1280054469.9990.16.camel@localhost>
Date:	Sun, 25 Jul 2010 13:41:09 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCHv5 12/15] writeback: optimize periodic bdi thread wakeups

On Sun, 2010-07-25 at 11:29 +0300, Artem Bityutskiy wrote:
> +static void wakeup_timer_fn(unsigned long data)
> +{
> +	struct backing_dev_info *bdi = (struct backing_dev_info *)data;
> +
> +	spin_lock(&bdi->wb_lock);
> +	if (bdi->wb.task) {
> +		wake_up_process(bdi->wb.task);
> +	} else {
> +		/*
> +		 * When bdi tasks are inactive for long time, they are killed.
> +		 * In this case we have to wake-up the forker thread which
> +		 * should create and run the bdi thread.
> +		 */
> +		wake_up_process(default_backing_dev_info.wb.task);
> +	}
> +	spin_unlock(&bdi->wb_lock);
> +}

OK, since now we use this lock in a timer, this should become a
spin_lock_bh().

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/