linux-kernel - RE: [PATCH] Don't apply for write lock on tasklist_lock if parent doesn't ptrace other processes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F4DF93C7785E2549970341072BC32CD752CEF3E4@irsmsx503.ger.corp.intel.com>
Date:	Mon, 26 Jul 2010 10:40:28 +0100
From:	"Kleen, Andi" <andi.kleen@...el.com>
To:	Oleg Nesterov <oleg@...hat.com>,
	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>
CC:	Roland McGrath <roland@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"stable@...nel.org" <stable@...nel.org>
Subject: RE: [PATCH] Don't apply for write lock on tasklist_lock if parent
	doesn't ptrace other processes

> The only difference is that we are doing the function call +
> list_empty()
> under tasklist, just a few instructions compared to "do a lot more
> work"
> in forget_original_parent().
> 
> How this can make the 2% difference ? This looks like a noise to me,
> or do you think I missed something?

It could be a cache miss or something like that. Instructions are not
all the same cost. Only detailed profiling with different performance counters
could give you more information.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/