linux-kernel - Re: [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in printk()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 26 Jul 2010 15:04:17 +0100
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Kulikov Vasiliy <segooon@...il.com>
Cc:	kernel-janitors@...r.kernel.org, Chris Dearman <chris@...s.com>,
	"Robert P. J. Day" <rpjday@...shcourse.ca>,
	Rusty Russell <rusty@...tcorp.com.au>,
	André Goddard Rosa <andre.goddard@...il.com>,
	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in
 printk()

On Wed, Jul 14, 2010 at 10:01:42PM +0400, Kulikov Vasiliy wrote:

> Use %p instead of %08x in printk().

Queued for 2.6.36, thanks!

Yes, %p is prefered here.  But your log message doesn't mention that your
patch also does a functional change, it drops the 0x prefix of the printed
value ...

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/