linux-kernel - Re: [PATCH] dlm: use genl_register_family_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100726160440.GA18604@redhat.com>
Date:	Mon, 26 Jul 2010 12:04:40 -0400
From:	David Teigland <teigland@...hat.com>
To:	Changli Gao <xiaosuo@...il.com>
Cc:	Christine Caulfield <ccaulfie@...hat.com>,
	cluster-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dlm: use genl_register_family_with_ops()

On Mon, Jul 26, 2010 at 05:19:19PM +0800, Changli Gao wrote:
> Signed-off-by: Changli Gao <xiaosuo@...il.com>
> ----
>  fs/dlm/netlink.c |   15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)
> diff --git a/fs/dlm/netlink.c b/fs/dlm/netlink.c
> index 2c6ad51..ef17e01 100644
> --- a/fs/dlm/netlink.c
> +++ b/fs/dlm/netlink.c
> @@ -81,24 +81,11 @@ static struct genl_ops dlm_nl_ops = {
>  
>  int __init dlm_netlink_init(void)
>  {
> -	int rv;
> -
> -	rv = genl_register_family(&family);
> -	if (rv)
> -		return rv;
> -
> -	rv = genl_register_ops(&family, &dlm_nl_ops);
> -	if (rv < 0)
> -		goto err;
> -	return 0;
> - err:
> -	genl_unregister_family(&family);
> -	return rv;
> +	return genl_register_family_with_ops(&family, &dlm_nl_ops, 1);
>  }
>  
>  void dlm_netlink_exit(void)
>  {
> -	genl_unregister_ops(&family, &dlm_nl_ops);
>  	genl_unregister_family(&family);
>  }

Looks fine, ack.
Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/