linux-kernel - Re: [git pull] drm-intel fixes since 2.6.35-rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Jul 2010 13:19:14 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Eric Anholt <eric@...olt.net>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [git pull] drm-intel fixes since 2.6.35-rc4

On Mon, Jul 26, 2010 at 12:13 PM, Eric Anholt <eric@...olt.net> wrote:
> The following changes since commit 815c4163b6c8ebf8152f42b0a5fd015cfdcedc78:
>
>  Linux 2.6.35-rc4 (2010-07-04 20:22:50 -0700)
>
> are available in the git repository at:
>  git://git.kernel.org/pub/scm/linux/kernel/git/anholt/drm-intel for-linus

Hmm. This seems to introduce a new warning:

  drivers/gpu/drm/i915/intel_dp.c:744: warning:
‘ironlake_edp_panel_off’ defined but not used

when I pulled it.

And the warning appears to be due to a real bug: instead of calling
ironlake_edp_panel_off(), the code calls ironlake_edp_backlight_off()
twice. I assume that the _intention_ was to call both the backlight
and panel "off" routines, rather than making doubly sure that just the
backlight is off by turning it off twice.

Tssk, tssk. Sadly, I noticed this too late, so now it's pulled and pushed out.

            Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/