| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <AANLkTikpON7WUkTLrnW4y2kghM=H8cLCAFst08S3cL_Z@mail.gmail.com> Date: Mon, 26 Jul 2010 16:51:01 -0600 From: Grant Likely <grant.likely@...retlab.ca> To: David Miller <davem@...emloft.net> Cc: sam@...nborg.org, sfr@...b.auug.org.au, monstr@...str.eu, microblaze-uclinux@...e.uq.edu.au, devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org, benh@...nel.crashing.org, sparclinux@...r.kernel.org Subject: Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() On Mon, Jul 26, 2010 at 4:48 PM, David Miller <davem@...emloft.net> wrote: > From: Grant Likely <grant.likely@...retlab.ca> > Date: Mon, 26 Jul 2010 16:42:20 -0600 > >> It protects against some later include file doing a #define >> of_node_to_nid and thus resulting in an inconsistent definition. If >> some code tries to do this then the preprocessor will complain. This >> is the pattern that Stephen suggested. > > Also, it would be nice to unravel the "0" vs. "-1" default > inconsistency. Indeed. I looked at it briefly, but it wasn't immediately clear what the impact would be to switch powerpc over to -1, and it looked to me like sparc depends on -1 to signify no node association. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists