linux-kernel - RE: [PATCH v2] Staging: dt3155: make local variables static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0D753D10438DA54287A00B02708426976374262C88@AUSP01VMBX24.collaborationhost.net>
Date:	Mon, 26 Jul 2010 18:09:44 -0500
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	Greg KH <greg@...ah.com>
CC:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"joe@...ches.com" <joe@...ches.com>,
	"ss@....gov.au" <ss@....gov.au>, "gregkh@...e.de" <gregkh@...e.de>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] Staging: dt3155: make local variables static

On Monday, July 26, 2010 3:35 PM, Greg KH wrote:
> On Fri, Jul 23, 2010 at 01:03:34PM -0700, H Hartley Sweeten wrote:
>> The symbols dt3155_dev_open, unique_tag, and allocatorAddr are only used in
>> the file dt3155_drv.c and should be static. Also, as pointed out by Joe Perches,
>> static variables do not need initialization so remove them. While here, also
>> move the definition for allocatorAddr so that all the variables are declared at
>> one place in the code.
>
> This doesn't apply after applying your previous patch to this file :(

Oops.. I'll fix it up and repost.

Regards,
Hartley--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/