linux-kernel - Re: [PATCH] tmio_mmc: Allow 2 byte requests in 4-bit mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin69UwXC3igcLnA9o0P==N2oV55Nj0vJt6WbSDS@mail.gmail.com>
Date:	Tue, 27 Jul 2010 17:05:33 +0900
From:	Magnus Damm <magnus.damm@...il.com>
To:	Ian Molton <ian@...menth.co.uk>
Cc:	Yusuke Goda <yusuke.goda.sx@...esas.com>, damm@...nsource.se,
	sameo@...ux.intel.com, Paul Mundt <lethal@...ux-sh.org>,
	g.liakhovetski@....de, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] tmio_mmc: Allow 2 byte requests in 4-bit mode

> On 23 July 2010 12:05, Magnus Damm <magnus.damm@...il.com> wrote:
>> 2010/7/20 Yusuke Goda <yusuke.goda.sx@...esas.com>:
>>> Adjust the tmio_mmc block size check to accept 2-byte requests in 4-bit mode.
>>> Tested with the SDHI hardware block included in sh7724.
>>>
>>> Signed-off-by: Yusuke Goda <yusuke.goda.sx@...esas.com>
>>
>> With this patch applied I can use SDIO cards in polling mode with the
>> tmio-mmc driver. Tested with the SDHI hardware block on sh7372 using
>> the b43 driver and BCM4318 hardware and the unfortunately out-of-tree
>> AR6002 "android" driver.
>>
>> Acked-by: Magnus Damm <damm@...nsource.se>
>>

Hi Ian,

Thanks for your feedback!

On Tue, Jul 27, 2010 at 4:57 PM, Ian Molton <ian@...menth.co.uk> wrote:
> This change needs to be modified to test what hardware is present.
> this wont work on my hardware TTBOMK.

Ok, just curious, on which platform did you test it?

On SDHI hardware the 2-byte access works just fine in 4-bit mode.

Thanks,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/