| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100727085350.GM26154@erda.amd.com> Date: Tue, 27 Jul 2010 10:53:50 +0200 From: Robert Richter <robert.richter@....com> To: "H. Peter Anvin" <hpa@...or.com> CC: Suresh Siddha <suresh.b.siddha@...el.com>, Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 6/7] x86, xsave: disable xsave in i387 emulation mode On 26.07.10 14:26:36, H. Peter Anvin wrote: > >> I think it is cleaner to clear these cpu capabilities in the function > >> which handles no387 boot parameter. > > > > This does not cover all (of course weird but potentially existing) > > cases. Disabling xsave in the no387 setup would only work if an fpu > > exists. > > If the fpu doesn't exist, then xsave can't exist, either. It does not convince me to move it either to no387 setup or xsave_init(). There is no benefit with both of it. We should disable it where we decide to use the soft fpu. Otherwise we will not have the same underlying rules for it. In case of xsave_init() we need to duplicate fpu code and export it to xsave code. I want to avoid this as xsave and fpu code should be kept simple and only be shared where necessary. -Robert -- Advanced Micro Devices, Inc. Operating System Research Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists