[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100727201644.2F46.A69D9226@jp.fujitsu.com>
Date: Tue, 27 Jul 2010 20:17:02 +0900 (JST)
From: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To: Eric B Munson <emunson@...bm.net>
Cc: kosaki.motohiro@...fujitsu.com, akpm@...ux-foundation.org,
mingo@...hat.com, hugh.dickins@...cali.co.uk, riel@...hat.com,
peterz@...radead.org, anton@...ba.org, hch@...radead.org,
linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 1/2] Add trace points to mmap, munmap, and brk
> On Wed, 21 Jul 2010, KOSAKI Motohiro wrote:
>
> > > This patch adds trace points to mmap, munmap, and brk that will report
> > > relevant addresses and sizes before each function exits successfully.
> > >
> > > Signed-off-by: Eric B Munson <emunson@...bm.net>
> >
> > I don't think this is good idea. if you need syscall result, you should
> > use syscall tracer. IOW, This tracepoint bring zero information.
> >
> > Please see perf_event_mmap() usage. Our kernel manage adress space by
> > vm_area_struct. we need to trace it if we need to know what kernel does.
> >
> > Thanks.
>
> The syscall tracer does not give you the address and size of the mmaped areas
> so this does provide information above simply tracing the enter/exit points
> for each call.
Why don't you fix this?
> perf_event_mmap does provide the information for mmap calls. Originally I sent
> a patch to add a trace point to munmap and Peter Z asked for corresponding points
> in the mmap family. If the consensus is that the trace point in munmap is the
> only one that should be added I can resend that patch.
>
> --
> Eric B Munson
> IBM Linux Technology Center
> ebmunson@...ibm.com
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists