linux-kernel - Re: [PATCH] ipmi: Fix memleaking for add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4C4EF03D.2000307@acm.org>
Date:	Tue, 27 Jul 2010 09:42:05 -0500
From:	Corey Minyard <minyard@....org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Matthew Garrett <mjg@...hat.com>,
	Len Brown <len.brown@...el.com>,
	Myron Stowe <myron.stowe@...com>,
	openipmi-developer@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi: Fix memleaking for add_smi when duplicating happen

On 07/26/2010 11:41 PM, Yinghai Lu wrote:
> On 07/26/2010 07:05 PM, Corey Minyard wrote:
>    
>> Please run this through checkpatch, as it has coding style violations.
>>      
> yhlu@...ux-siqj:~/xx/xx/kernel/tip/linux-2.6>  ./scripts/checkpatch.pl patches/ipmi_reg_size.patch
> total: 0 errors, 0 warnings, 105 lines checked
>
> patches/ipmi_reg_size.patch has no obvious style problems and is ready for submission.
> yhlu@...ux-siqj:~/xx/xx/kernel/tip/linux-2.6>
>    
Sorry, you are right.

>    
>> Also, this patch appears to fix bugs in addition to adding the print.
>> Can we have a separate patch for that?
>>      
> in the comment log, i already mentioned that.
>
> will separate it to twol
>    
Ok, thanks

>    
>> I'm also not clear on the reason for this.  I believe all this
>> information is already available in /proc/ipmi/<if#>/params.  I don't
>> think there is a strong reason to print it to the log.
>>      
> then why there is printing for ACPI path and pci path?
>    
Well, I'm not sure on this.  You are right, it is printed for those 
paths and not for DMI or SPMI cases.  Printing too much information is 
not generally a good idea, but this may be useful.  I guess to make it 
consistent it would be best to add this.

-corey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/