linux-kernel - Re: [PATCH] gpio: remove spurious gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100727153231.GA7072@pengutronix.de>
Date:	Tue, 27 Jul 2010 17:32:31 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Gregory Bean <gbean@...eaurora.org>, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Jani Nikula <ext-jani.1.nikula@...ia.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Jon Povey <jon.povey@...elogic.co.uk>
Subject: Re: [PATCH] gpio: remove spurious gpio_unexport debug error.

Hello Andrew,

On Mon, Jul 26, 2010 at 03:32:36PM -0700, Andrew Morton wrote:
> On Fri, 23 Jul 2010 06:58:07 +0200
> Uwe Kleine-K__nig <u.kleine-koenig@...gutronix.de> wrote:
> 
> > Hello,
> > 
> > On Thu, Jul 22, 2010 at 02:05:58PM -0700, Gregory Bean wrote:
> > > Make gpio_unexport generate success instead of an -EINVAL
> > > if asked to unexport a line which is not exported, because
> > > the only result of that condition is a pr_debug
> > > which complains of what is really a harmless no-op:
> > > when an unexported gpio is unexported again, nothing happens.
> > > That's not a failure, just a trivial border case.
> > > Since gpio_free calls gpio_unexport unconditionally
> > > and exported gpio lines are uncommon, most calls to
> > > gpio_free with debug flags enabled generate -EINVAL
> > > warnings in the log, causing unnecessary stress.
> > I noticed that a few days ago, too.  Just didn't come around to fix it
> > myself.
> >  
> > > Signed-off-by: Gregory Bean <gbean@...eaurora.org>
> > Acked-by: Uwe Kleine-K__nig <u.kleine-koenig@...gutronix.de>
> > 
> 
> Jon got there first ;)
OK, then he can get my ack, too.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/