linux-kernel - Re: [PATCH] ipmi: Run a dummy command before submitting a new command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C4F123F.3010700@mvista.com>
Date:	Tue, 27 Jul 2010 12:07:11 -0500
From:	Corey Minyard <cminyard@...sta.com>
To:	Matthew Garrett <mjg@...hat.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi: Run a dummy command before submitting a new command

I don't think this is the right way to handle the problem.  Though it's 
not going to break anything, this change is just a hack.  We need to 
figure out why these machine exhibit this behavior.  If it's a bug in 
the driver, then we need to fix the driver.  If it's a bug in the HP 
firmware, then we need to document it well as such, get HP to fix their 
firmware, and possibly tie it into the xaction handler that's already in 
start_next_msg.

The only interaction with the device that this change should cause is 
one read from the status register, since the device should be idle at 
this point.  If that's the case, and it's not a driver bug, you can try 
adding an xaction that calls smi_info->handlers->event(smi_info->si_sm, 0).

There are debugging flags in the state machines that might help debug 
this, too.

-corey

On 07/27/2010 11:01 AM, Matthew Garrett wrote:
> Newer firmware revisions on HP's ILO3 (1.05 and later) generate state
> machine errors with the current IPMI code. Running through the IPMI
> timeout handler once before submitting the command avoids this.
>
> Signed-off-by: Matthew Garrett<mjg@...hat.com>
> Cc: Corey Minyard<cminyard@...sta.com>
> ---
>   drivers/char/ipmi/ipmi_si_intf.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index e39a744..3f06199 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -317,6 +317,7 @@ static int unload_when_empty = 1;
>   static int add_smi(struct smi_info *smi);
>   static int try_smi_init(struct smi_info *smi);
>   static void cleanup_one_si(struct smi_info *to_clean);
> +static void smi_timeout(unsigned long data);
>
>   static ATOMIC_NOTIFIER_HEAD(xaction_notifier_list);
>   static int register_xaction_notifier(struct notifier_block *nb)
> @@ -897,6 +898,7 @@ static void sender(void                *send_info,
>   #endif
>
>   	mod_timer(&smi_info->si_timer, jiffies + SI_TIMEOUT_JIFFIES);
> +	smi_timeout((unsigned long)smi_info);
>
>   	if (smi_info->thread)
>   		wake_up_process(smi_info->thread);
>    

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/