linux-kernel - Re: [PATCH] aic7xxx: Remove OS utility wrappers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1280252404.2833.168.camel@mulgrave.site>
Date:	Tue, 27 Jul 2010 12:40:04 -0500
From:	James Bottomley <James.Bottomley@...e.de>
To:	Hannes Reinecke <hare@...e.de>
Cc:	Pekka Enberg <penberg@...helsinki.fi>,
	linux-kernel@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	André Goddard Rosa <andre.goddard@...il.com>,
	linux-scsi@...r.kernel.org
Subject: Re: [PATCH] aic7xxx: Remove OS utility wrappers

On Mon, 2010-07-19 at 08:42 +0200, Hannes Reinecke wrote:
> Pekka Enberg wrote:
> > This patch removes malloc(), free(), and printf() wrappers from the aic7xxx
> > SCSI driver. I didn't use pr_debug for printf because of some 'clever' uses of
> > printf don't compile with the pr_debug. I didn't fix the overeager uses of
> > GFP_ATOMIC either because I wanted to keep this patch as simple as possible.
> > 
> > Cc: Hannes Reinecke <hare@...e.de>
> > Cc: "James E.J. Bottomley" <James.Bottomley@...e.de>
> > Cc: Jiri Kosina <jkosina@...e.cz>
> > Cc: "Uwe Kleine-König" <u.kleine-koenig@...gutronix.de>
> > Cc: "André Goddard Rosa" <andre.goddard@...il.com>
> > Cc: <linux-scsi@...r.kernel.org>
> > Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
> 
> Thanks for the work. Long overdue.
> 
> Acked-by: Hannes Reinecke <hare@...e.de>

A good rule of thumb is compile before acking:

drivers/scsi/aic7xxx/aic7770.c: In function 'aic7770_config':
drivers/scsi/aic7xxx/aic7770.c:224: error: implicit declaration of function 'free'
drivers/scsi/aic7xxx/aic7770.c:224: error: 'M_DEVBUF' undeclared (first use in this function)
drivers/scsi/aic7xxx/aic7770.c:224: error: (Each undeclared identifier is reported only once
drivers/scsi/aic7xxx/aic7770.c:224: error: for each function it appears in.)
make[3]: *** [drivers/scsi/aic7xxx/aic7770.o] Error 1

It looks like a lone missed conversion, so I fixed it up.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/