linux-kernel - [tip:x86/irq] x86-32: Align IRQ stacks properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-25897374297906eeebef8864299406bdcb5859c3@git.kernel.org>
Date:	Tue, 27 Jul 2010 18:36:48 GMT
From:	tip-bot for Christoph Hellwig <hch@....de>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	hch@....de, tglx@...utronix.de
Subject: [tip:x86/irq] x86-32: Align IRQ stacks properly

Commit-ID:  25897374297906eeebef8864299406bdcb5859c3
Gitweb:     http://git.kernel.org/tip/25897374297906eeebef8864299406bdcb5859c3
Author:     Christoph Hellwig <hch@....de>
AuthorDate: Tue, 27 Jul 2010 14:13:13 +0200
Committer:  H. Peter Anvin <hpa@...or.com>
CommitDate: Tue, 27 Jul 2010 10:06:54 -0700

x86-32: Align IRQ stacks properly

As suggested by Steven Rostedt we need to align the IRQ stacks to the
stack size, not just the page size to make them work for stack traces
and other things that depend on finding the stack slot itself with 8k
stacks.

Signed-off-by: Christoph Hellwig <hch@....de>
LKML-Reference: <20100727121313.GA19976@....de>
Signed-off-by: H. Peter Anvin <hpa@...or.com>
---
 arch/x86/kernel/irq_32.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/irq_32.c b/arch/x86/kernel/irq_32.c
index 67f5f9f..3b5609f 100644
--- a/arch/x86/kernel/irq_32.c
+++ b/arch/x86/kernel/irq_32.c
@@ -55,7 +55,7 @@ static inline void print_stack_overflow(void) { }
 union irq_ctx {
 	struct thread_info      tinfo;
 	u32                     stack[THREAD_SIZE/sizeof(u32)];
-} __attribute__((aligned(PAGE_SIZE)));
+} __attribute__((aligned(THREAD_SIZE)));
 
 static DEFINE_PER_CPU(union irq_ctx *, hardirq_ctx);
 static DEFINE_PER_CPU(union irq_ctx *, softirq_ctx);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/