linux-kernel - Re: [PATCH 9/9] x86: Detect whether we should use Xen SWIOTLB.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C4F2D9C.4020303@zytor.com>
Date:	Tue, 27 Jul 2010 12:03:56 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	alex.williamson@...hat.com,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Albert Herranz <albert_herranz@...oo.es>,
	Ian Campbell <Ian.Campbell@...rix.com>,
	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH 9/9] x86: Detect whether we should use Xen SWIOTLB.

On 07/27/2010 10:00 AM, Konrad Rzeszutek Wilk wrote:
> It is paramount that we call pci_xen_swiotlb_detect before
> pci_swiotlb_detect as both implementations use the 'swiotlb'
> and 'swiotlb_force' flags. The pci-xen_swiotlb_detect inhibits
> the swiotlb_force and swiotlb flag so that the native SWIOTLB
> implementation is not enabled when running under Xen.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
> Cc: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
> Cc: Albert Herranz <albert_herranz@...oo.es>
> Cc: Ian Campbell <Ian.Campbell@...rix.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: x86@...nel.org
> Cc: Jesse Barnes <jbarnes@...tuousgeek.org>
> ---
>  arch/x86/kernel/pci-dma.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 

Is there any way we can abstract this out a bit more instead of crapping
on generic code?

	-hpa
-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/