[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1280270347-4409-4-git-send-email-ppannuto@codeaurora.org>
Date: Tue, 27 Jul 2010 15:39:06 -0700
From: Patrick Pannuto <ppannuto@...eaurora.org>
To: linux-kernel@...r.kernel.org
Cc: ppannuto@...eaurora.org, Andy Whitcroft <apw@...onical.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Joe Perches <joe@...ches.com>
Subject: [PATCH 3/4] Checkpatch: prefer usleep_range over usleep
In (almost) every case, usleep_range is better than
usleep, as the precise (ish) wakeup - more accurately
the extra interrupt - from usleep is unnecessary.
usleep_range gives a much better chance of coalescing
processor wakeups.
Signed-off-by: Patrick Pannuto <ppannuto@...eaurora.org>
---
scripts/checkpatch.pl | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e3625ac..0650ab9 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2578,6 +2578,11 @@ sub process {
}
}
+# prefer usleep_range over usleep
+ if ($line =~ /\busleep\s*\(.+\);/) {
+ WARN("usleep_range is preferred over usleep; see Documentation/timers/delays.txt\n" . $line);
+ }
+
# warn about #ifdefs in C files
# if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
# print "#ifdef in C files should be avoided\n";
--
1.7.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists