lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Jul 2010 03:50:31 -0400 From: Mike Frysinger <vapier.adi@...il.com> To: Joe Perches <joe@...ches.com> Cc: Michael Hennerich <michael.hennerich@...log.com>, uclinux-dist-devel <uclinux-dist-devel@...ckfin.uclinux.org>, LKML <linux-kernel@...r.kernel.org>, netdev <netdev@...r.kernel.org> Subject: Re: [Uclinux-dist-devel] [PATCH net-next] drivers/net/bfin_mac.c: Use pr_fmt, netdev_<level> On Tue, Jul 27, 2010 at 15:22, Joe Perches wrote: > And some assorted neatening for checkpatch: > > 80 column reformatting (mostly comments) > argument alignment > couple of spelling/grammar typos corrected > > Added bfin_alloc_skb to centralize allocation/dcache invalidation > Added get_mac_addr for symmetry > > $ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:" > total: 2 errors, 25 warnings, 1723 lines checked > $ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:" > total: 0 errors, 0 warnings, 1743 lines checked > > Uncompiled, untested. i dislike the mixing of whitespace and useful changes if they were split, and they worked, then i wouldnt have a problem with them -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists