linux-kernel - Re: [PATCHv2 2/4] mm: cma: Contiguous Memory Allocator added

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <op.vgjpm3it7p4s8u@pikus>
Date:	Wed, 28 Jul 2010 10:53:17 +0200
From:	Michał Nazarewicz <m.nazarewicz@...sung.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Daniel Walker <dwalker@...eaurora.org>,
	Jonathan Corbet <corbet@....net>,
	Pawel Osciak <p.osciak@...sung.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org, Hiremath Vaibhav <hvaibhav@...com>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	linux-mm@...ck.org, Kyungmin Park <kyungmin.park@...sung.com>,
	Zach Pfeffer <zpfeffer@...eaurora.org>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org
Subject: Re: [PATCHv2 2/4] mm: cma: Contiguous Memory Allocator added

>> +static inline dma_addr_t __must_check
>> +cma_alloc(const struct device *dev, const char *kind,
>> +	  size_t size, dma_addr_t alignment)
>> +{
>> +	return dev ? -EINVAL : __cma_alloc(dev, kind, size, alignment);

On Tue, 27 Jul 2010 14:08:41 +0200, Russell King - ARM Linux <linux@....linux.org.uk> wrote:
> So I can't use this to allocate memory for anything but a NULL device?

>> +static inline int
>> +cma_info(struct cma_info *info, const struct device *dev, const char *kind)
>> +{
>> +	return dev ? -EINVAL : __cma_info(info, dev, kind);

> This won't return information for anything but a NULL device?

Obviously a bug.  Thanks for spotting that.

-- 
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/