| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Jul 2010 15:25:59 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Michal Nazarewicz <m.nazarewicz@...sung.com> Cc: Greg KH <greg@...ah.com>, David Brownell <david-b@...bell.net>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCHv5 3/3] USB: gadget: storage_common: fixed warning building mass storage function On Wed, Jul 28, 2010 at 3:13 PM, Michal Nazarewicz <m.nazarewicz@...sung.com> wrote: > The "nofua" attribute is used in the File-Storage Gadget but the > functions handling it are defined in storage_common.c (which may be > not a bad thing if anyone will want to port tho "nofua" attribute to > mass storage function) which causes the following warnings: > > drivers/usb/gadget/storage_common.c:718: \ > warning: ‘fsg_show_nofua’ defined but not used > drivers/usb/gadget/storage_common.c:782: \ > warning: ‘fsg_store_nofua’ defined but not used > > Adding __maybe_unused fixes this issue. It's a bit odd. Why the warning happens for those two only? There are two more parameters (four methods) to handle 'ro' and 'file' which are done in the same way. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists