linux-kernel - Re: [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by strict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Jul 2010 21:43:54 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Ernesto Ramos <ernesto@...com>
Cc:	gregkh@...e.de, omar.ramirez@...com, ohad@...ery.com,
	ameya.palande@...ia.com, felipe.contreras@...ia.com,
	fernando.lugo@...com, linux-kernel@...r.kernel.org, nm@...com,
	linux-omap@...r.kernel.org
Subject: Re: [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by 
	strict_strtoul

On Wed, Jul 28, 2010 at 5:40 PM, Ernesto Ramos <ernesto@...com> wrote:
> Replace simple_strtoul by strict_strtoul in atoi function.
In general the question what is the purpose here to do the change?

> @@ -1023,7 +1025,9 @@ static s32 atoi(char *psz_buf)
>                base = 16;
>        }
>
> -       return simple_strtoul(pch, NULL, base);
> +       ret_val = strict_strtoul(pch, base, &res);
> +
> +       return ret_val ? : res;
May be better to use explicit values in condition?

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/