linux-kernel - Re: [PATCH] video/w100fb: ignore void return value / fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C507EB0.8050208@nachtwindheim.de>
Date:	Wed, 28 Jul 2010 21:02:08 +0200
From:	Henrik Kretzschmar <henne@...htwindheim.de>
To:	Peter Hüwe <PeterHuewe@....de>
CC:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	Arnaud Patard <arnaud.patard@...-net.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jaya Kumar <jayakumar.lkml@...il.com>,
	linux-kernel@...r.kernel.org,
	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Kernel Janitors <kernel-janitors@...r.kernel.org>,
	Jiri Kosina <trivial@...nel.org>
Subject: Re: [PATCH] video/w100fb: ignore void return value / fix build failure

Am 28.07.2010 20:29, schrieb Peter Hüwe:
> From: Peter Huewe <peterhuewe@....de>
> 
> This patch fixes a build failure [1] (error: void value not ignored as
> it ought to be) by removing an assignment of a void return value.
> The functionality of the code is not changed.
> 
> Signed-off-by: Peter Huewe <peterhuewe@....de>
Ached-by: Henrik Kretzschmar <henne@...htwindheim.de>
> ---
> KernelVersion: linux-next-20100728
> References:
> [1] http://kisskb.ellerman.id.au/kisskb/buildresult/2980912/
> 
>  drivers/video/w100fb.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/w100fb.c b/drivers/video/w100fb.c
> index e66b8b1..d8b12c3 100644
> --- a/drivers/video/w100fb.c
> +++ b/drivers/video/w100fb.c
> @@ -858,9 +858,9 @@ unsigned long w100fb_gpio_read(int port)
>  void w100fb_gpio_write(int port, unsigned long value)
>  {
>  	if (port==W100_GPIO_PORT_A)
> -		value = writel(value, remapped_regs + mmGPIO_DATA);
> +		writel(value, remapped_regs + mmGPIO_DATA);
>  	else
> -		value = writel(value, remapped_regs + mmGPIO_DATA2);
> +		writel(value, remapped_regs + mmGPIO_DATA2);
>  }
>  EXPORT_SYMBOL(w100fb_gpio_read);
>  EXPORT_SYMBOL(w100fb_gpio_write);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/