linux-kernel - Re: [PATH V2 2/5] Package Level Thermal Control and Power Limit Notification: pkgtemp hwmon driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1280345147.1830.57.camel@groeck-laptop>
Date:	Wed, 28 Jul 2010 12:25:47 -0700
From:	Guenter Roeck <guenter.roeck@...csson.com>
To:	Fenghua Yu <fenghua.yu@...el.com>
CC:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	H Peter Anvin <hpa@...or.com>, Len Brown <lenb@...nel.org>,
	Chen Gong <gong.chen@...ux.intel.com>,
	Jean Delvare <khali@...ux-fr.org>,
	Huaxu Wan <huaxu.wan@...el.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	lm-sensors <lm-sensors@...sensors.org>
Subject: Re: [PATH V2 2/5] Package Level Thermal Control and Power Limit
 Notification: pkgtemp hwmon driver

On Wed, 2010-07-28 at 15:00 -0400, Fenghua Yu wrote:
> From: Fenghua Yu <fenghua.yu@...el.com>
> 
> This patch adds a hwmon driver for package level thermal control. The driver
> dumps package level thermal information through sysfs interface so that upper
> level application (e.g. lm_sensor) can retrive the information.
> 
> Instead of having the package level hwmon code in coretemp, I write a seperate
> driver pkgtemp because:
> 
> First, package level thermal sensors include not only sensors for each core,
> but also sensors for uncore, memory controller or other components in the
> package. Logically it will be clear to have a seperate hwmon driver for package
> level hwmon to monitor wider range of sensors in a package. Merging package
> thermal driver into core thermal driver doesn't make sense and may mislead.
> 
> Secondly, merging the two drivers together may cause coding mess. It's easier
> to include various package level sensors info if more sensor information is
> implemented. Coretemp code needs to consider a lot of legacy machine cases.
> Pkgtemp code only considers platform starting from Sandy Bridge.
> 
> On a 1Sx4Cx2T Sandy Bridge platform, lm-sensors dumps the pkgtemp and coretemp:
> 
> pkgtemp-isa-0000
> Adapter: ISA adapter
> physical id 0: +33.0°C  (high = +79.0°C, crit = +99.0°C)
> 
> coretemp-isa-0000
> Adapter: ISA adapter
> Core 0:      +32.0°C  (high = +79.0°C, crit = +99.0°C)
> 
> coretemp-isa-0001
> Adapter: ISA adapter
> Core 1:      +32.0°C  (high = +79.0°C, crit = +99.0°C)
> 
> coretemp-isa-0002
> Adapter: ISA adapter
> Core 2:      +32.0°C  (high = +79.0°C, crit = +99.0°C)
> 
> coretemp-isa-0003
> Adapter: ISA adapter
> Core 3:      +32.0°C  (high = +79.0°C, crit = +99.0°C)
> 
> Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
> Reviewed-by: Len Brown <len.brown@...el.com>
> Reviewed-by: Guenter Roeck <guenter.roeck@...csson.com>

That I provided feedback does not mean that I endorsed a "Reviewed-by"
signature. It is inappropriate to add such a signature without my
approval.

Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/