linux-kernel - Re: [PATCH 09/10] oss: msnd: check request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Jul 2010 22:00:02 +0200
From:	Dan Carpenter <error27@...il.com>
To:	Kulikov Vasiliy <segooon@...il.com>
Cc:	kernel-janitors@...r.kernel.org, Andrew Veliath <andrewtv@....net>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Arnd Bergmann <arnd@...db.de>, Tejun Heo <tj@...nel.org>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/10] oss: msnd: check request_region() return value

On Wed, Jul 28, 2010 at 08:41:36PM +0400, Kulikov Vasiliy wrote:
> request_region() may fail, if so return -ENOMEM.
> 
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>
> ---
>  sound/oss/msnd_pinnacle.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/oss/msnd_pinnacle.c b/sound/oss/msnd_pinnacle.c
> index bfaac5f..cd70b9a 100644
> --- a/sound/oss/msnd_pinnacle.c
> +++ b/sound/oss/msnd_pinnacle.c
> @@ -1400,9 +1400,13 @@ static int __init attach_multisound(void)
>  		printk(KERN_ERR LOGNAME ": Couldn't grab IRQ %d\n", dev.irq);
>  		return err;
>  	}
> -	request_region(dev.io, dev.numio, dev.name);

This should be -EBUSY as well.  The same for "[PATCH 06/10] ALSA: msnd: 
check request_region() return value"

Another way to write that would be:

-	request_region(dev.io, dev.numio, dev.name);
+	err = request_region(dev.io, dev.numio, dev.name);
+	if (err) {
+		free_irq(dev.irq, &dev);
+		return err;
+	}

regards,
dan carpenter

> +	if (request_region(dev.io, dev.numio, dev.name) == NULL) {
> +		free_irq(dev.irq, &dev);
> +		return -ENOMEM;
> +	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/