linux-kernel - Re: [PATCH 2/2] s6e63m0: fix section mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100728153116.634dc64b.akpm@linux-foundation.org>
Date:	Wed, 28 Jul 2010 15:31:16 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Richard Purdie <rpurdie@...ys.net>,
	InKi Dae <inki.dae@...sung.com>
Subject: Re: [PATCH 2/2] s6e63m0: fix section mismatch

On Wed, 28 Jul 2010 11:07:36 +0800
Axel Lin <axel.lin@...il.com> wrote:

> Eliminate section mismatch warning by marking s6e63m0_probe() as __devinit.
> 

Please aways quote the error messages or warnings when fixing build
errors or warnings.  It helps with the review quite a lot.

> 
> diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
> index b27ccf9..1757379 100644
> --- a/drivers/video/backlight/s6e63m0.c
> +++ b/drivers/video/backlight/s6e63m0.c
> @@ -732,7 +732,7 @@ static ssize_t s6e63m0_sysfs_show_gamma_table(struct device *dev,
>  static DEVICE_ATTR(gamma_table, 0644,
>  		s6e63m0_sysfs_show_gamma_table, NULL);
>  
> -static int __init s6e63m0_probe(struct spi_device *spi)
> +static int __devinit s6e63m0_probe(struct spi_device *spi)
>  {
>  	int ret = 0;
>  	struct s6e63m0 *lcd = NULL;

Many drivers/video/backlight/*.c drivers use __devinit for the
platform_driver.probe handler.  Quite a lot use nothing (ie: .text). 
Some still use __init.  About half of them use __devexit_p for .remove
and half don't.  It looks like it all needs a bit of loving care.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/