lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Jul 2010 17:06:36 -0700 From: "Luis R. Rodriguez" <mcgrof@...il.com> To: Maxim Levitsky <maximlevitsky@...il.com> Cc: Matthew Garrett <mjg59@...f.ucam.org>, "ath5k-devel@...ts.ath5k.org" <ath5k-devel@...ts.ath5k.org>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, David Quan <David.Quan@...eros.com>, "Luis R. Rodriguez" <mcgrof@...badil.infradead.org>, linux-kernel <linux-kernel@...r.kernel.org>, "kernel-team@...ts.ubuntu.com" <kernel-team@...ts.ubuntu.com>, Luis Rodriguez <Luis.Rodriguez@...eros.com>, Jussi Kivilinna <jussi.kivilinna@...et.fi>, "tim.gardner@...onical.com" <tim.gardner@...onical.com> Subject: Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM On Wed, Jul 28, 2010 at 4:48 PM, Maxim Levitsky <maximlevitsky@...il.com> wrote: > On Tue, 2010-07-27 at 08:57 -0700, Luis R. Rodriguez wrote: >> On Tue, Jul 27, 2010 at 2:35 AM, Maxim Levitsky <maximlevitsky@...il.com> wrote: >> > On Mon, 2010-07-26 at 23:50 +0100, Matthew Garrett wrote: >> >> On Mon, Jul 26, 2010 at 03:43:04PM -0700, Luis R. Rodriguez wrote: >> >> >> >> > I see.. thanks Mathew... in that case since L1 works on all devices we >> >> > could just force enable L1 for all PCIE devices. What do you think? >> >> >> >> Works for me. >> >> >> > >> > On the second thought, there is no 'pci_enable_link_state' :-) >> > I afraid that if I add it, I might not do that right for all cases, thus >> > do more harm that good... >> >> I'm sorry, can you elaborate? > > I mean ASPM code doesn't have a function to undo effects of the > blacklist (due to pre 1.1 pcie device). > > Its not that simple to write such function. Ah good catch... pcie_aspm_sanity_check() will actually be used to adjust the device link capability... So even if we do try to insist it wouldn't work. I'm happy if we deal with this separately, its a reasonable compromise to fix issues with existing devices out there. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists